Kerberos support for node-postgres#3267
Conversation
blackentropy
force-pushed
the
add-kerberos
branch
from
c853f08 to
93f30ed
Compare
packages/pg/lib/client.js
Outdated
|
|
||
| // TODO: probably a better way to handle this. | ||
| if (token == null) { | ||
| this.emit('error', 'Received null GSSAPI token on continue') |
There was a problem hiding this comment.
Just a quick note; the token can be null if the negotiation has already been successfully completed. I suspect the right thing to do is to do something like:
if (inToken === 'oRQwEqADCgEAoQsGCSqGSIb3EgECAg==') {
return; // negotiation successful, no need to do anything further.
}
see: https://github.com/jcmturner/gokrb5/blob/master/spnego/http.go#L198 for where that magic string came from.
|
@brianc We'd ideally like to get this merged and released through the main package. Could you let us know what the procedure would be? There's unfortunately not a lot of documentation for this flow, and it's not well trodden. |
I can do that! Its very easy on my side to release new versions. Ideally all features should have tests along side them. I realize testing against a kerberos system is.... unpleasant ... do you have any way you could include tests? Even the |
|
@albertchang note also: CI is running on this PR now & lint is failing |
Cool, I'll try to take a stab at writing some tests for this change and circle back afterwards. Thanks! Also, is CI not configured to run automatically on changes to the branch? |
Boo i need to set that up. having to keep re-approving it is no bueno! |
albertchang
force-pushed
the
add-kerberos
branch
from
061c305 to
e12441f
Compare
handle accept token return if no token step
albertchang
force-pushed
the
add-kerberos
branch
from
e12441f to
bd3d9a2
Compare
|
@brianc Could you approve the workflow run for CI? Thanks! |
|
@brianc Would also appreciate a review when you get a chance! |
blackentropy
changed the title
3 participants
No description provided.